internal/transport: avoid mutating request URL for https+insecure - #1017
Merged
Conversation
aalexand
enabled auto-merge (squash)
August 23, 2026 23:57
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 67.35% 67.20% -0.15%
==========================================
Files 44 45 +1
Lines 7793 7846 +53
==========================================
+ Hits 5249 5273 +24
- Misses 2112 2133 +21
- Partials 432 440 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aalexand
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transport.RoundTripshallow-copies the request when handlinghttps+insecure, but the copied request still shares the original*url.URL.As a result, changing the copied URL scheme from
https+insecuretohttpsalso mutates the caller's request.Copy the
url.URLvalue and update the copied request to point to the new value. Add a regression test that verifies the HTTPS request succeeds and the caller's URL scheme remains unchanged.